Skip to content

[release-4.19] OCPBUGS-57086: [Default Catalog Consistency Test]: Cherry-picks for Catalog Tests: Fix JUnit format, rename test suite, and enable Catalog Tests for Sippy/TRT integration #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jun 4, 2025

/cherrypick release-4.18 release-4.17

How to validate those changes

Screenshot 2025-06-04 at 21 32 30

To know more about those tests see: https://docs.google.com/document/d/10aLllNnN24XFBbRwWlXIN_nLLKU68GOnBANEygExcCk/edit?tab=t.0#heading=h.x3tfh25grvnv

@camilamacedo86 camilamacedo86 changed the title [Default Catalog Consistency Test]: Cherry-Picks [release-4.19] OCPBUGS-57019, OPRUN-3914: [Default Catalog Consistency Test]: Cherry-Picks Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 4, 2025

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57019, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56956 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56956 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references OPRUN-3914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "4.20" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from anik120 and thetechnick June 4, 2025 18:21
@camilamacedo86 camilamacedo86 changed the title [release-4.19] OCPBUGS-57019, OPRUN-3914: [Default Catalog Consistency Test]: Cherry-Picks [release-4.19] OCPBUGS-57019: [Default Catalog Consistency Test]: Cherry-Picks up 4.17 Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57019, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title [release-4.19] OCPBUGS-57019: [Default Catalog Consistency Test]: Cherry-Picks up 4.17 [release-4.19] OCPBUGS-57086: [Default Catalog Consistency Test]: Cherry-Picks up 4.17 Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57086, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56956 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56956 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

/hold until we get merged: #372

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57086, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56956 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56956 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2025
@camilamacedo86
Copy link
Contributor Author

@oceanc80 We will need your help on this one :-)

Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57086, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56956 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56956 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/cherrypick release-4.18 release-4.17

How to validate those changes

Screenshot 2025-06-04 at 21 32 30

To know more about those tests see: https://docs.google.com/document/d/10aLllNnN24XFBbRwWlXIN_nLLKU68GOnBANEygExcCk/edit?tab=t.0#heading=h.x3tfh25grvnv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-57086, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56956 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56956 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bandrade
Copy link

bandrade commented Jun 5, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 5, 2025
@oceanc80
Copy link
Contributor

oceanc80 commented Jun 9, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 9, 2025
@tmshort
Copy link
Contributor

tmshort commented Jun 9, 2025

Is the title correct? "4.17"?

@tmshort
Copy link
Contributor

tmshort commented Jun 9, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@camilamacedo86 camilamacedo86 changed the title [release-4.19] OCPBUGS-57086: [Default Catalog Consistency Test]: Cherry-Picks up 4.17 [release-4.19] OCPBUGS-57086: [Default Catalog Consistency Test]: Cherry-picks for Catalog Tests: Fix JUnit format, rename test suite, and enable Catalog Tests for Sippy/TRT integration Jun 9, 2025
@tmshort
Copy link
Contributor

tmshort commented Jun 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 416a2d3 into openshift:release-4.19 Jun 9, 2025
11 checks passed
@openshift-ci-robot
Copy link

@camilamacedo86: Jira Issue OCPBUGS-57086: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-57086 has not been moved to the MODIFIED state.

In response to this:

/cherrypick release-4.18 release-4.17

How to validate those changes

Screenshot 2025-06-04 at 21 32 30

To know more about those tests see: https://docs.google.com/document/d/10aLllNnN24XFBbRwWlXIN_nLLKU68GOnBANEygExcCk/edit?tab=t.0#heading=h.x3tfh25grvnv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@camilamacedo86: #374 failed to apply on top of branch "release-4.18":

Applying: UPSTREAM: <carry>: [Default Catalog Consistency Test]: fix junit output format to allow generate xml
Applying: UPSTREAM: <carry>: [Default Catalog Consistency Test]: Enable CatalogChecks
Applying: UPSTREAM: <carry>: [Default Catalog Consistency Test]: Rename Tests suite and small cleanups
Using index info to reconstruct a base tree...
M	openshift/default-catalog-consistency/test/validate/suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging openshift/default-catalog-consistency/test/validate/suite_test.go
CONFLICT (content): Merge conflict in openshift/default-catalog-consistency/test/validate/suite_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0003 UPSTREAM: <carry>: [Default Catalog Consistency Test]: Rename Tests suite and small cleanups

In response to this:

/cherrypick release-4.18 release-4.17

How to validate those changes

Screenshot 2025-06-04 at 21 32 30

To know more about those tests see: https://docs.google.com/document/d/10aLllNnN24XFBbRwWlXIN_nLLKU68GOnBANEygExcCk/edit?tab=t.0#heading=h.x3tfh25grvnv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.19.0-202506091514.p0.g416a2d3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.19.0-202506091514.p0.g416a2d3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.